Skip to content

caching_sha2_password can now be used without TLS #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anarthal merged 69 commits into from
Jun 7, 2025
Merged

caching_sha2_password can now be used without TLS #480

anarthal merged 69 commits into from
Jun 7, 2025

Conversation

@anarthal
Copy link
Collaborator

@anarthal anarthal commented May 11, 2025

close #313

anarthal added 30 commits May 9, 2025 16:16
@anarthal
Initial impl
080ada8
@anarthal
Fix integration tests
a7a0b74
@anarthal
simplify integration tests
0a3ee27
@anarthal
Fixed scramble size
8804521
@anarthal
update challenge => scramble terminology
063d46a
@anarthal
remove assertion
a1eb3ff
@anarthal
Move encryption function to a separate file
9bfd88b
@anarthal
Prototype to test openssl edge cases
b26efd6
@anarthal
Fixed regression in csha2p hashing
17cc582
@anarthal
unit tests now build again
4ae5fb9
@anarthal
test cases for encrypt
6514182
@anarthal
unit test strategy
b206dcf
@anarthal
encrypt success cases 1
36d53d9
@anarthal
8192 key
fc3b258
@anarthal
all characters test
07eaee8
@anarthal
Sanitize translate_openssl_error
dbefe00
@anarthal
empty key buffer test
b74b234
@anarthal
key errors
a5b60db
@anarthal
empty password
0b9a192
@anarthal
proper handling of EVP_PKEY_CTX_set_rsa_padding failure
d9bcb58
@anarthal
make success cases use parametric tests
985b5a5
@anarthal
integration test
6b21e68
@anarthal
fix mocking tests
9dc5abc
@anarthal
use Boost.Test
380dd60
@anarthal
track num calls
e3cb4d1
@anarthal
more edge cases
463d2d5
@anarthal
refactor and fixes
1e7f38a
@anarthal
finished mocking tests
ae32f4f
@anarthal
Added algo_test::expect_any_write
193664a
@anarthal
first handshake_csha2p test
efef293
anarthal added 25 commits June 2, 2025 20:29
@anarthal
remove spurius includes
03a96a1
@anarthal
Remove problematic openssl/types.h include
2859abe
@anarthal
Fixed a memory corruption
cc247cb
@anarthal
Add client_errc::unknown_openssl_error
3d7b42a
@anarthal
make things fail even if openssl does not provide extra error info
a70479e
@anarthal
Use EVP_PKEY_size for compatibility
dd2e4fa
@anarthal
test system errors
af8b222
@anarthal
remove unnecessary static_buffer::resize
f9c1e29
@anarthal
Remove TODO
47fd214
@anarthal
Disable problematic PFR check
426e34f
@anarthal
remove Jamfile comment
153c226
@anarthal
rephrase docs
aa32bd3
@anarthal
fix edge case with scramble sizes
a2faaad
@anarthal
Recover build_unix_local structure
2370f8a
@anarthal
restrict the errors test to openssl 3+
cb0ac8c
@anarthal
fix span conversion problems
969ef52
@anarthal
introduce size check and simplify
170144b
@anarthal
relax check in key_not_rsa
209aeee
@anarthal
correct the check and add tests
1ce0d52
@anarthal
fix unreliable test across openssl versions
54fa0d8
@anarthal
fix narrowing conversion
0e840e9
@anarthal
Disable PFR problematic tests
09de831
@anarthal
Fix narrowing conversion warning
dbfd8ab
@anarthal
Fixed PFR problem
11ad921
@anarthal
Workaround PFR MSVC problem
a045836
@codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (90405e7) to head (dfb962a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #480   +/-   ##
========================================
  Coverage    99.15%   99.15%           
========================================
  Files          143      144    +1     
  Lines         7297     7370   +73     
========================================
+ Hits          7235     7308   +73     
  Misses          62       62
Files with missing lines Coverage Δ
include/boost/mysql/client_errc.hpp 100.00% <ø> (ø)
include/boost/mysql/impl/error_categories.ipp 98.80% <100.00%> (+0.02%) ⬆️
...sql/impl/internal/sansio/caching_sha2_password.hpp 100.00% <100.00%> (ø)
...l/impl/internal/sansio/csha2p_encrypt_password.hpp 100.00% <100.00%> (ø)
...ude/boost/mysql/impl/internal/sansio/handshake.hpp 99.31% <100.00%> (+0.08%) ⬆️
...sql/impl/internal/sansio/mysql_native_password.hpp 100.00% <100.00%> (ø)
include/boost/mysql/impl/is_fatal_error.ipp 100.00% <100.00%> (ø)
include/boost/mysql/impl/pfr.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90405e7...dfb962a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anarthal anarthal merged commit 6a82609 into develop Jun 7, 2025
6 checks passed
@anarthal anarthal deleted the feature/313-csha2p-plaintext branch June 7, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

caching_sha2_password should not require SSL

2 participants

@anarthal